Skip to content

Update Media Element Metadata - #521

Draft
James Crutchley (ne0rrmatrix) wants to merge 2 commits into
MicrosoftDocs:mainfrom
ne0rrmatrix:UpdateMetadata
Draft

James Crutchley (ne0rrmatrix) wants to merge 2 commits into
MicrosoftDocs:mainfrom
ne0rrmatrix:UpdateMetadata

Conversation

@ne0rrmatrix

Copy link
Copy Markdown
Contributor

Add support for Media Element MetadataArtwork source to be set as a MediaSource and support file, embed, and Url's.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8253a2f:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/views/MediaElement.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@TheCodeTraveler

Copy link
Copy Markdown
Contributor

Hi James! This is Brandon's Claude.

Thank you for writing these docs! I ported CommunityToolkit/Maui#2502 onto current main, and its API changed from your original design: MetadataArtworkUrl stays (marked [Obsolete]) and the new property is MetadataArtworkSource. I rewrote MediaElement.md to match, but I can't push to your branch, because maintainer edits need write access to this repo.

The rewrite sits on top of your commits in TheCodeTraveler/CommunityToolkitDocs:docs/pr-2502-artwork, and it also merges main in. Could you merge it into UpdateMetadata? It's a fast-forward:

git checkout UpdateMetadata
git pull https://github.com/TheCodeTraveler/CommunityToolkitDocs.git docs/pr-2502-artwork
git push

Thanks again!

@ne0rrmatrix

Copy link
Copy Markdown
Contributor Author

Brandon Minnick (@TheCodeTraveler) thank you for porting this and for the rewrite. I have not merged docs/pr-2502-artwork into UpdateMetadata yet, and I should not do it from this fork.

My fork (ne0rrmatrix/CommunityToolkit) was cut off from this repo when the repo went away and came back: its parent is now bijington/CommunityToolkit. A push to it no longer reaches the PR. I found that out on #446, where one push to the head branch closed the PR and left it with no commits and no diff. The pull and push you describe would do the same here.

Where things stand:

  • This PR is untouched: still open, with its two commits.
  • To take your rewrite, UpdateMetadata has to move to my new fork, ne0rrmatrix/CommunityToolkitFixed, with your branch merged in there, and that needs a replacement PR. None of that is done yet.
  • If it is quicker for you, your branch already has my commits with your rewrite on top, so a PR from TheCodeTraveler/CommunityToolkitDocs:docs/pr-2502-artwork would carry everything. I am fine with that, and this PR can then be closed in favour of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maui The .NET MAUI Community Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants